Skip to content

Commit d16418f

Browse files
ChengYanJing-carre
andauthored
Update .claude/skills/review-pr/SKILL.md
Co-authored-by: Guillaume CARRE <122804551+g-carre@users.noreply.github.com>
1 parent f93f947 commit d16418f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ gh pr diff <number> --repo <owner/repo>
4444
| Kubernetes operator | RBAC scoping (least-privilege), reconciler idempotency, status subresource updates only via `Status().Update()` |
4545
| Interface compliance | Verify implementations satisfy interfaces at compile time (e.g. `var _ SomeInterface = &MyType{}`) |
4646
| TypeScript/React | Prop changes (missing/wrong types), missing `key` props in lists, proper hook usage, no `console.log` in production code |
47-
| Scality dep pinning | `@scality/core-ui`, `@scality/module-federation`, `@kubernetes/client-node` must be pinned to a specific tag/commit, not a branch |
47+
| Scality dep pinning | `@scality/core-ui`, `@scality/module-federation` must be pinned to a specific tag/commit, not a branch |
48+
| External dep pinning | `@kubernetes/client-node` must be pinned to a specific git tag in package.json |
4849
| Salt states | Correct use of requisites (`require`, `watch`, `onchanges`); no hardcoded credentials; proper Jinja templating |
4950
| Helm/Kustomize | Resource limits set, security contexts defined, proper label selectors, upgrade path preserved |
5051
| Python | No bare `except:`; specific exception types; type hints on new functions; no blocking calls in async context |

0 commit comments

Comments
 (0)