Refactor volume deletion logic to use CustomObjectsApi and improve error handling

Author: hervedombya

ui/src/services/k8s/Metalk8sLocalVolumeProvider.test.ts

@@ -1,31 +1,27 @@
 import { CoreV1Api, CustomObjectsApi } from '@kubernetes/client-node';
+import { updateApiServerConfig } from './api';
 import Metalk8sLocalVolumeProvider, {
   VolumeType,
 } from './Metalk8sLocalVolumeProvider';
-import { updateApiServerConfig } from './api';
-import { Metalk8sV1alpha1VolumeClient } from './Metalk8sVolumeClient.generated';
 
 jest.mock('../k8s/api', () => ({
   updateApiServerConfig: jest.fn(),
 }));
 
+const MOCK_GROUP = 'storage.metalk8s.scality.com';
+const MOCK_VERSION = 'v1alpha1';
+const MOCK_PLURAL = 'volumes';
+
 describe('Metalk8sLocalVolumeProvider', () => {
   let provider: Metalk8sLocalVolumeProvider;
   const mockUrl = 'mock-url';
   const mockToken = jest.fn(() => Promise.resolve('mock-token'));
 
   const mockCustomObjectsApi = {
     listClusterCustomObject: jest.fn(),
+    deleteClusterCustomObject: jest.fn(),
   } as unknown as CustomObjectsApi;
 
-  const mockVolumeClient = {
-    deleteMetalk8sV1alpha1Volume: jest.fn().mockResolvedValue({ body: {} }),
-    getMetalk8sV1alpha1VolumeList: jest.fn(),
-    getMetalk8sV1alpha1Volume: jest.fn(),
-    createMetalk8sV1alpha1Volume: jest.fn(),
-    patchMetalk8sV1alpha1Volume: jest.fn(),
-  } as unknown as Metalk8sV1alpha1VolumeClient;
-
   const mockCoreV1Api = {
     listNode: jest.fn(),
     listPersistentVolume: jest.fn(),
@@ -71,7 +67,7 @@ describe('Metalk8sLocalVolumeProvider', () => {
       });
 
       (
-        mockVolumeClient.getMetalk8sV1alpha1VolumeList as jest.Mock
+        mockCustomObjectsApi.listClusterCustomObject as jest.Mock
       ).mockResolvedValue({
         body: {
           items: [
@@ -153,7 +149,7 @@ describe('Metalk8sLocalVolumeProvider', () => {
       });
 
       (
-        mockVolumeClient.getMetalk8sV1alpha1VolumeList as jest.Mock
+        mockCustomObjectsApi.listClusterCustomObject as jest.Mock
       ).mockRejectedValue(new Error('Failed to fetch volumes'));
 
       await expect(
@@ -168,7 +164,7 @@ describe('Metalk8sLocalVolumeProvider', () => {
     it('should detach hardware volumes and virtual volumes', async () => {
       //S
       (
-        mockVolumeClient.deleteMetalk8sV1alpha1Volume as jest.Mock
+        mockCustomObjectsApi.deleteClusterCustomObject as jest.Mock
       ).mockResolvedValue({
         body: {},
       });
@@ -191,17 +187,29 @@ describe('Metalk8sLocalVolumeProvider', () => {
       ]);
       //V
       expect(
-        mockVolumeClient.deleteMetalk8sV1alpha1Volume,
-      ).toHaveBeenCalledWith('test-volume');
+        mockCustomObjectsApi.deleteClusterCustomObject,
+      ).toHaveBeenCalledWith(
+        MOCK_GROUP,
+        MOCK_VERSION,
+        MOCK_PLURAL,
+        'test-volume',
+        {},
+      );
       expect(
-        mockVolumeClient.deleteMetalk8sV1alpha1Volume,
-      ).toHaveBeenCalledWith('test-lvm');
+        mockCustomObjectsApi.deleteClusterCustomObject,
+      ).toHaveBeenCalledWith(
+        MOCK_GROUP,
+        MOCK_VERSION,
+        MOCK_PLURAL,
+        'test-lvm',
+        {},
+      );
     });
 
     it('should raise an error if metalk8s volume deletion fails', async () => {
       //S
       (
-        mockVolumeClient.deleteMetalk8sV1alpha1Volume as jest.Mock
+        mockCustomObjectsApi.deleteClusterCustomObject as jest.Mock
       ).mockRejectedValue(new Error('Failed to delete metalk8s volume'));
       //E+V
       await expect(

ui/src/services/k8s/Metalk8sLocalVolumeProvider.ts

@@ -78,7 +78,7 @@ export default class Metalk8sLocalVolumeProvider {
 
         return localPv;
       } else {
-        throw new Error(`Failed to fetch metalk8s volumes: ${volumes.error}`);
+        throw new Error(`${volumes.error.message}`);
       }
     } catch (error) {
       throw new Error(
@@ -99,7 +99,15 @@ export default class Metalk8sLocalVolumeProvider {
 
     for (const volumeName of volumeNames) {
       try {
-        await volumeClient.deleteMetalk8sV1alpha1Volume(volumeName);
+        const deleteVolume = await volumeClient.deleteMetalk8sV1alpha1Volume(
+          volumeName,
+        );
+
+        if (isError(deleteVolume)) {
+          throw new Error(
+            `Failed to delete MetalK8s volume ${volumeName}: ${deleteVolume.error.message}`,
+          );
+        }
       } catch (error) {
         throw new Error(
           `Failed to delete MetalK8s volume ${volumeName}: ${