ARTESCA-14895: Add detach volumes method in Metalk8sLocalvolumeProvider by ChengYanJin · Pull Request #4545 · scality/metalk8s

ChengYanJin · 2025-03-25T15:34:46Z

Component: UI

Context:

Summary: Add detach volumes method in Metalk8sLocalvolumeProvider

Acceptance criteria:

Closes: #ISSUE_NUMBER

bert-e · 2025-03-25T15:35:01Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-03-25T15:35:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-03-26T12:51:47Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2025-03-26T15:33:56Z

/approve

bert-e · 2025-03-26T16:14:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2025-03-26T17:05:47Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider into
development/129.0
w/130.0/feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider will be merged into development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2025-03-26T17:05:48Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2025-03-26T17:39:38Z

History mismatch

Merge commit #a52bf70017d0e34c751c4d501aaf7c34e4bf5ed7 on the integration branch
w/130.0/feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider is merging a branch which is neither the current
branch feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider nor the development branch
development/130.0.

It is likely due to a rebase of the branch feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

ChengYanJin · 2025-03-26T17:41:46Z

/reset

bert-e · 2025-03-26T17:41:54Z

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

bert-e · 2025-03-26T17:42:03Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider into
development/129.0
w/130.0/feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider will be merged into development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2025-03-26T17:42:04Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2025-03-27T10:57:14Z

Build failed

The build for commit did not succeed in branch w/130.0/feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider

The following options are set: approve

bert-e · 2025-03-27T13:22:35Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/129.0
✔️ development/130.0

The following branches have NOT changed:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue ARTESCA-14895.

Goodbye chengyanjin.

The following options are set: approve

ChengYanJin marked this pull request as ready for review March 25, 2025 15:37

ChengYanJin requested a review from a team as a code owner March 25, 2025 15:37

ChengYanJin force-pushed the feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider branch 3 times, most recently from 0abfeb7 to 7576b09 Compare March 26, 2025 12:51

ChengYanJin force-pushed the feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider branch from 7576b09 to 8bf7b3d Compare March 26, 2025 12:59

hervedombya previously approved these changes Mar 26, 2025

View reviewed changes

ChengYanJin dismissed hervedombya’s stale review via a52bf70 March 26, 2025 16:14

ChengYanJin force-pushed the feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider branch from 8bf7b3d to a52bf70 Compare March 26, 2025 16:14

MonPote reviewed Mar 26, 2025

View reviewed changes

Comment thread ui/src/services/k8s/Metalk8sLocalVolumeProvider.ts Outdated

ChengYanJin changed the base branch from development/130.0 to development/129.0 March 26, 2025 17:05

ChengYanJin added 2 commits March 26, 2025 18:39

ARTESCA-14895: Add detach volumes method in Metalk8sLocalvolumeProvider

1c03871

ARTESCA-14895: Replace for loop by map

41caeb5

ChengYanJin force-pushed the feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider branch from 4776ad0 to 41caeb5 Compare March 26, 2025 17:39

MonPote approved these changes Mar 27, 2025

View reviewed changes

bert-e merged commit 41caeb5 into development/129.0 Mar 27, 2025
30 checks passed

bert-e deleted the feature/ARTESCA-14895-new-detach-method-in-Metalk8sLocalVolumeProvider branch March 27, 2025 13:22

Conversation

ChengYanJin commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Mar 25, 2025

Hello chengyanjin,

Uh oh!

bert-e commented Mar 25, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 26, 2025

Waiting for approval

Uh oh!

ChengYanJin commented Mar 26, 2025

Uh oh!

bert-e commented Mar 26, 2025

Waiting for approval

Uh oh!

Uh oh!

bert-e commented Mar 26, 2025

Integration data created

Uh oh!

bert-e commented Mar 26, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 26, 2025

History mismatch

Uh oh!

ChengYanJin commented Mar 26, 2025

Uh oh!

bert-e commented Mar 26, 2025

Reset complete

Uh oh!

bert-e commented Mar 26, 2025

Integration data created

Uh oh!

bert-e commented Mar 26, 2025

Waiting for approval

Uh oh!

bert-e commented Mar 27, 2025

Build failed

Uh oh!

bert-e commented Mar 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ChengYanJin commented Mar 25, 2025 •

edited

Loading