Skip to content

ARTESCA-14994 - Bump thanos kube prometheus stack and Thanos#4569

Closed
vdaviot wants to merge 4 commits intodevelopment/130.0from
improvement/ARTESCA-14994-bump-thanos-kube-prometheus-stack
Closed

ARTESCA-14994 - Bump thanos kube prometheus stack and Thanos#4569
vdaviot wants to merge 4 commits intodevelopment/130.0from
improvement/ARTESCA-14994-bump-thanos-kube-prometheus-stack

Conversation

@vdaviot
Copy link
Copy Markdown
Contributor

@vdaviot vdaviot commented Apr 14, 2025

No description provided.

@vdaviot vdaviot requested a review from a team as a code owner April 14, 2025 12:26
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 14, 2025

Hello vdaviot,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 14, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@vdaviot vdaviot changed the title Improvement/artesca 14994 bump thanos kube prometheus stack ARTESCA-14994 - Bump thanos kube prometheus stack and Thanos Apr 14, 2025
vdaviot added 2 commits April 14, 2025 13:39
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
Comment on lines -78 to +107
[2.55.0](https://github.com/prometheus/prometheus/releases/tag/v2.55.0)
[2.55.1](https://github.com/prometheus/prometheus/releases/tag/v2.55.1)
- Bump Thanos container version to
[0.36.1](https://github.com/thanos-io/thanos/releases/tag/v0.36.1)
[0.38.0](https://github.com/thanos-io/thanos/releases/tag/v0.38.0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro wtf, cursor is crazy sometimes
the funniest part is i actually saw the behavior and told it to do it again, reverted all his changes...
but he still modified stuff

alriiiiight

Comment on lines -96 to +123
[0.77.2](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.77.2)
[0.81.0](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.81.0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines 1586 to 1614
metrics for those filesystem does not bring any value
(PR[#3661](https:github.com/scality/metalk8s/pull/3661))
(PR[#3661](https://github.com/scality/metalk8s/pull/3661))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more for the road

- Bump grafana chart version to
[8.11.0](https://github.com/grafana/helm-charts/releases/tag/grafana-8.11.0)

- Bump thanos chart from Banzaicloud to Bitnami version
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these charts are freely interchangible.
here we just want to bump the image and handle using a new chart in a different feature/ticket

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright 👍 I was waiting for the CI to tell me I was wrong to even try

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem will happen during upgrade actually (maybe before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants