prometheus: add an alert for CronJob owned Job failure and another for non Cronjob owned Job by ezekiel-alexrod · Pull Request #4584 · scality/metalk8s

ezekiel-alexrod · 2025-04-24T12:39:48Z

No description provided.

bert-e · 2025-04-24T12:39:51Z

Hello ezekiel-alexrod,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-04-24T12:39:57Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-04-24T14:07:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-04-28T15:35:32Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-04-29T07:45:12Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-04-29T10:05:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

CHANGELOG.md

salt/metalk8s/addons/prometheus-operator/config/prometheus.yaml

salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls

TeddyAndrieux

.

bert-e · 2025-04-29T12:14:59Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux

The following options are set: approve

TeddyAndrieux

LGTM (just waiting for the new rule extract to approve)

…r non Cronjob owned Job

bert-e · 2025-05-05T13:27:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux

ezekiel-alexrod · 2025-05-05T13:44:11Z

/approve

bert-e · 2025-05-05T13:44:19Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@TeddyAndrieux

The following options are set: approve

bert-e · 2025-05-05T15:43:04Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/130.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/129.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-05-05T17:50:01Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/130.0

The following branches have NOT changed:

development/123.0
development/124.0
development/124.1
development/125.0
development/126.0
development/127.0
development/128.0
development/129.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye ezekiel-alexrod.

ezekiel-alexrod force-pushed the improvement/add-cronjob-jobs-alerts branch from 1985188 to e0bca42 Compare April 24, 2025 12:51

ezekiel-alexrod marked this pull request as ready for review April 24, 2025 17:08

ezekiel-alexrod requested a review from a team as a code owner April 24, 2025 17:08

eg-ayoub previously approved these changes Apr 25, 2025

View reviewed changes

ezekiel-alexrod force-pushed the improvement/add-cronjob-jobs-alerts branch from e0bca42 to 419dd85 Compare April 28, 2025 15:35

ezekiel-alexrod dismissed eg-ayoub’s stale review via 3436d69 April 29, 2025 07:45

ezekiel-alexrod force-pushed the improvement/add-cronjob-jobs-alerts branch from 419dd85 to 3436d69 Compare April 29, 2025 07:45

ezekiel-alexrod requested review from a team and eg-ayoub April 29, 2025 07:45

TeddyAndrieux reviewed Apr 29, 2025

View reviewed changes

TeddyAndrieux requested changes Apr 29, 2025

View reviewed changes

ezekiel-alexrod force-pushed the improvement/add-cronjob-jobs-alerts branch from 3436d69 to a680163 Compare April 30, 2025 07:56

ezekiel-alexrod requested review from a team and TeddyAndrieux April 30, 2025 08:00

TeddyAndrieux reviewed Apr 30, 2025

View reviewed changes

prometheus: add an alert for CronJob owned Job failure and another fo…

ad9c130

…r non Cronjob owned Job

ezekiel-alexrod force-pushed the improvement/add-cronjob-jobs-alerts branch from a680163 to ad9c130 Compare May 5, 2025 13:27

TeddyAndrieux approved these changes May 5, 2025

View reviewed changes

bert-e merged commit 26243d6 into development/130.0 May 5, 2025
30 checks passed

bert-e deleted the improvement/add-cronjob-jobs-alerts branch May 5, 2025 17:50

Conversation

ezekiel-alexrod commented Apr 24, 2025

Uh oh!

bert-e commented Apr 24, 2025

Hello ezekiel-alexrod,

Uh oh!

bert-e commented Apr 24, 2025

Waiting for approval

Uh oh!

bert-e commented Apr 24, 2025

Waiting for approval

Uh oh!

bert-e commented Apr 28, 2025

Waiting for approval

Uh oh!

bert-e commented Apr 29, 2025

Waiting for approval

Uh oh!

bert-e commented Apr 29, 2025

Waiting for approval

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TeddyAndrieux left a comment

Choose a reason for hiding this comment

Uh oh!

bert-e commented Apr 29, 2025

Waiting for approval

Uh oh!

TeddyAndrieux left a comment

Choose a reason for hiding this comment

Uh oh!

bert-e commented May 5, 2025

Waiting for approval

Uh oh!

ezekiel-alexrod commented May 5, 2025

Uh oh!

bert-e commented May 5, 2025

Waiting for approval

Uh oh!

bert-e commented May 5, 2025

In the queue

Uh oh!

bert-e commented May 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants