Skip to content

Add ui-operator addon structure#4628

Merged
bert-e merged 1 commit intodevelopment/131.0from
feature/create-addon-structure-for-ui-operator
Jul 31, 2025
Merged

Add ui-operator addon structure#4628
bert-e merged 1 commit intodevelopment/131.0from
feature/create-addon-structure-for-ui-operator

Conversation

@hervedombya
Copy link
Copy Markdown
Contributor

Component:

Context:

Summary:

Acceptance criteria:


Closes: #ISSUE_NUMBER

@hervedombya hervedombya requested a review from a team as a code owner July 30, 2025 12:20
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 30, 2025

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 30, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the feature/create-addon-structure-for-ui-operator branch 2 times, most recently from 14e92c5 to bbac933 Compare July 30, 2025 13:53
Comment thread buildchain/buildchain/salt_tree.py Outdated
Comment thread salt/metalk8s/addons/ui-operator/deployed/manifests.sls.in Outdated
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 30, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@hervedombya hervedombya force-pushed the feature/create-addon-structure-for-ui-operator branch 2 times, most recently from 5464c00 to 329efff Compare July 30, 2025 15:59
MonPote
MonPote previously approved these changes Jul 30, 2025
Comment thread salt/metalk8s/addons/ui-operator/deployed/manifests.sls Outdated
Comment thread salt/metalk8s/addons/ui-operator/deployed/namespace.sls Outdated
fix: remove trailing whitespace and ensure consistent formatting in ui-operator addon files

fix: update ui-operator deployment and related configurations

review: replace template file with direct manifests.sls for ui-operator deployment

refactor: remove unnecessary shebang and restructure namespace definition for ui-operator

fix: remove trailing whitespace in manifests.sls for ui-operator addon

feat: add POD_NAMESPACE environment variable to ui-operator deployment

refactor: update ui-operator deployment manifest structure for clarity

refactor: streamline namespace definition in ui-operator manifest
@hervedombya hervedombya force-pushed the feature/create-addon-structure-for-ui-operator branch from b0a6e20 to ad91116 Compare July 31, 2025 08:36
Copy link
Copy Markdown
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervedombya
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 31, 2025

Build failed

The build for commit did not succeed in branch feature/create-addon-structure-for-ui-operator

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 31, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/131.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/129.0
  • development/130.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye hervedombya.

The following options are set: approve

@bert-e bert-e merged commit ad91116 into development/131.0 Jul 31, 2025
54 of 55 checks passed
@bert-e bert-e deleted the feature/create-addon-structure-for-ui-operator branch July 31, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants