Conversation
MonPote
force-pushed
the
improvement/add-runtime-plugin
branch
from
ed03c25 to
ba9b9ac
Compare
JBWatenbergScality
approved these changes
Jan 26, 2026
Comment on lines
+56
to
+72
| test('should override a nested string value using __ separator', () => { | ||
| process.env.MICRO_APP_RUNTIME_selfConfiguration__managementEndpoint = '/new/endpoint'; | ||
|
|
||
| const plugin = new MicroAppRuntimeConfigurationPlugin(createDefaultConfig()); | ||
| const config = getConfig(plugin); | ||
|
|
||
| expect(config.spec.selfConfiguration.managementEndpoint).toBe('/new/endpoint'); | ||
| }); | ||
|
|
||
| test('should override deeply nested values', () => { | ||
| process.env.MICRO_APP_RUNTIME_auth__clientId = 'new-client-id'; | ||
|
|
||
| const plugin = new MicroAppRuntimeConfigurationPlugin(createDefaultConfig()); | ||
| const config = getConfig(plugin); | ||
|
|
||
| expect(config.spec.auth.clientId).toBe('new-client-id'); | ||
| }); |
Collaborator
There was a problem hiding this comment.
nit: I think those 2 tests are the same ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.