S3CSI-220: Add hostPID to node DaemonSet with OpenShift auto-detection#319
Draft
anurag4DSB wants to merge 1 commit intomainfrom
Draft
S3CSI-220: Add hostPID to node DaemonSet with OpenShift auto-detection#319anurag4DSB wants to merge 1 commit intomainfrom
anurag4DSB wants to merge 1 commit intomainfrom
Conversation
Port hostPID support from upstream. Add isOpenShift value with auto- detection via SecurityContextConstraints API. hostPID=true for vanilla K8s, false for OpenShift. Fixes silent data corruption on multi-process writes. Issue: S3CSI-220
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 47 47
Lines 2669 2669
=======================================
Hits 1919 1919
Misses 622 622
Partials 128 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isOpenShiftHelm value with auto-detection via SecurityContextConstraints APIhostPID: truefor vanilla K8s,hostPID: falsefor OpenShiftDependencies
Changes
values.yaml: AddisOpenShift: null(auto-detect by default)_helpers.tpl: AddisOpenShifthelpernode.yaml: Add conditionalhostPIDto DaemonSet pod specTest Plan
helm templaterendershostPID: trueby defaulthelm template --set isOpenShift=truerendershostPID: falseIssue: S3CSI-220