S3CSI-225: Port prefix parsing fix from upstream PR #658#324
Draft
anurag4DSB wants to merge 2 commits intomainfrom
Draft
S3CSI-225: Port prefix parsing fix from upstream PR #658#324anurag4DSB wants to merge 2 commits intomainfrom
anurag4DSB wants to merge 2 commits intomainfrom
Conversation
Fix S3 bucket prefix parsing that could mount wrong prefix or fail entirely when prefix values contain equals signs. Uses whichever separator (space or equals) appears first. Issue: S3CSI-225
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 71.89% 71.92% +0.02%
==========================================
Files 47 47
Lines 2669 2671 +2
==========================================
+ Hits 1919 1921 +2
Misses 622 622
Partials 128 128 |
Adds an E2E test that verifies the --prefix mount option works correctly when the prefix value contains equals signs (e.g., prefix=env=prod/). This is a regression test for the parser fix that ensures the first separator (space vs equals) is used, preventing value truncation. Issue: S3CSI-225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
=split first, corrupting prefixes with=charactersChanges
pkg/mountpoint/args.go: ReplaceParseArgs()parsing logic with upstream fixpkg/mountpoint/args_test.go: Add 4 new regression test cases for prefixes with=Test Plan
TestParsingMountpointArgsunit tests pass (including 4 new)"prefix kwk3-di/sub=vault/"correctly parses to--prefix=kwk3-di/sub=vault/=signs (e.g.,prefix=env=prod/) work correctly end-to-end — files stored under the full prefix in S3Issue: S3CSI-225