S3CSI-228: Add createNamespace Helm toggle and NOTES.txt#326
Draft
anurag4DSB wants to merge 1 commit intomainfrom
Draft
S3CSI-228: Add createNamespace Helm toggle and NOTES.txt#326anurag4DSB wants to merge 1 commit intomainfrom
anurag4DSB wants to merge 1 commit intomainfrom
Conversation
Add mountpointPod.createNamespace boolean for ArgoCD/GitOps compatibility. Add NOTES.txt with upgrade guidance about Mountpoint pods not auto-recreating on driver upgrade. Issue: S3CSI-228
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 71.89% 72.19% +0.29%
==========================================
Files 47 47
Lines 2669 2669
==========================================
+ Hits 1919 1927 +8
+ Misses 622 614 -8
Partials 128 128 |
Collaborator
Author
|
Needs docs update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mountpointPod.createNamespaceboolean toggle for ArgoCD/GitOps compatibilityNOTES.txtwith post-install guidance and upgrade warnings about Mountpoint pod lifecycletrue(backward compatible)Changes
values.yaml: AddcreateNamespace: trueundermountpointPodtemplates/mount-s3-namespace.yaml: Wrap namespace creation in conditionaltemplates/NOTES.txt: New Scality-branded install/upgrade notesTest Plan
helm templaterenders namespace by defaulthelm template --set mountpointPod.createNamespace=falseomits namespacemage e2e:installexercises default createNamespace=true path. NOTES.txt renders on every helm install.Issue: S3CSI-228