S3CSI-224: Reject -o mount option with InvalidArgument error#346
Open
anurag4DSB wants to merge 1 commit intomainfrom
Open
S3CSI-224: Reject -o mount option with InvalidArgument error#346anurag4DSB wants to merge 1 commit intomainfrom
anurag4DSB wants to merge 1 commit intomainfrom
Conversation
Previously the driver silently stripped the fstab-style -o flag from mount options, giving no feedback to users who specified it. This change makes -o an explicit rejection at NodePublishVolume time: the driver returns an InvalidArgument gRPC error, so the pod event immediately shows a clear, actionable message instead of mounting silently with the flag ignored. Includes unit and E2E test updates to assert the rejection behaviour, a mountpoint version bump to 1.22.0, and documentation updates: - Release notes classify this as a breaking change with a migration note - Troubleshooting guide adds the new error to the Mount Issues table - Mount options reference adds an "Unsupported Syntax" section Issue: S3CSI-224
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-oflag frommountOptions, giving no indication to users that the flag was unsupported. After upgrade, any PV or StorageClass carrying-owould mount without it — silently ignoring user intent.-oan explicit rejection:NodePublishVolumereturns anInvalidArgumentgRPC error with a clear message, causing the pod event to surface the issue immediately with actionable guidance.-oinmountOptionswill see pod failures after upgrade. The migration path is simply to remove the-oentries (they were always ignored and had no effect on the mount).Breaking Change
Any PV or StorageClass that has
-oinmountOptionswill fail to mount after this upgrade.Migration: Remove
-oentries frommountOptions. If the intent was to pass options like-o uid=1000,allow-other, specify each option as its own entry instead:Test plan
make test-oin PVmountOptionsfails withnot supported in CSI Driverevent-oin StorageClassmountOptionsfails withnot supported in CSI Drivereventmake docs— verify Troubleshooting and Mount Options pages show new contentIssue: S3CSI-224