Skip to content

S3CSI-29: Add tests suite for prefix, region and read-only mountoptions #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anurag4DSB
Copy link

@anurag4DSB anurag4DSB commented May 19, 2025

Added tests for volume level options for specifying --region (overrides driver level region), --prefix (mounts bucket using a specific prefix), and --read-only (for read only filesystem)

The test cases added are either important for us or we have changed the related options behaviour so we need to test.
The rest of the scenarios are testing in the upstream mountpoint-s3

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (7fd9fdf) to head (da692b6).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

see 1 file with indirect coverage changes

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   64.78%   64.83%   +0.04%     
==========================================
  Files          37       37              
  Lines        2090     2090              
==========================================
+ Hits         1354     1355       +1     
+ Misses        660      659       -1     
  Partials       76       76              

@anurag4DSB anurag4DSB force-pushed the improvement/S3CSI-29-Add-tests-suite-for-remaining-mountoptions branch 2 times, most recently from fe6bfda to cfe083c Compare May 19, 2025 14:44
@anurag4DSB anurag4DSB marked this pull request as ready for review May 19, 2025 14:50
@anurag4DSB anurag4DSB force-pushed the improvement/S3CSI-29-Add-tests-suite-for-remaining-mountoptions branch from 759cb43 to da692b6 Compare May 20, 2025 07:03
@anurag4DSB anurag4DSB merged commit 1f61012 into main May 20, 2025
9 checks passed
@anurag4DSB anurag4DSB deleted the improvement/S3CSI-29-Add-tests-suite-for-remaining-mountoptions branch May 20, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants