Skip to content

✨ add automatic projet desactivation and retag#19

Merged
m4nch0t merged 3 commits into
mainfrom
feature/add-cron-project-desactivation
Jun 11, 2026
Merged

✨ add automatic projet desactivation and retag#19
m4nch0t merged 3 commits into
mainfrom
feature/add-cron-project-desactivation

Conversation

@m4nch0t

@m4nch0t m4nch0t commented May 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@m4nch0t m4nch0t requested a review from a team as a code owner May 21, 2026 13:29

@TeddyAndrieux TeddyAndrieux left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not reviewed the whole content just few comments otherwise I'm ok if it works:

  • Current pre-merge seems to fail
  • The new tests you added in this PR does not seems to run in pre-merge

Comment thread src/cli/commands.py

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it make a lot of sense to have it in the repo, or maybe it should be changed in some DESIGN.md or something like that, that state what we are doing and why but a plan does not make much sense IMHO

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it was an experiment, based on https://code.visualstudio.com/docs/agent-customization/prompt-files
Since we deploy AI review, it may be the correct way to give context to the LLM in charge of the review?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's a good idea to me having a DESIGN.md or so, that would contains the reason for each decision would be better than having the "prompt file" used to do this feature, especially if at some point we rework the part you did with a prompt using another one it might be hard for the AI to pick the right one (it may even pick older "prompt file" and do a totally wrong review)

I don't know what is the good approach for it

@scality scality deleted a comment from TeddyAndrieux Jun 11, 2026

@TeddyAndrieux TeddyAndrieux left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's works, ok for me

@m4nch0t m4nch0t merged commit c0951cd into main Jun 11, 2026
1 check passed
@m4nch0t m4nch0t deleted the feature/add-cron-project-desactivation branch June 12, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants