Skip to content

fix: ingress reconcilation exposer#57

Merged
MonPote merged 1 commit intomainfrom
fix/fix-servicePort-error
Jul 31, 2025
Merged

fix: ingress reconcilation exposer#57
MonPote merged 1 commit intomainfrom
fix/fix-servicePort-error

Conversation

@hervedombya
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 31, 2025 14:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes ingress reconciliation in the ScalityUIComponentExposer by removing hardcoded service port configuration and adding proper test setup and coverage for ingress functionality.

  • Removes hardcoded ServicePort "80" from ingress reconciler configuration
  • Adds operator info initialization in test suite to prevent invalid label values
  • Introduces comprehensive test coverage for ingress reconciliation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/controller/scalityuicomponentexposer/ingress.go Removes hardcoded ServicePort configuration from ingress reconciler
internal/controller/scalityuicomponentexposer/suite_test.go Adds operator info initialization for test environment
internal/controller/scalityuicomponentexposer/controller_test.go Adds new test case for ingress reconciliation validation
Comments suppressed due to low confidence (2)

internal/controller/scalityuicomponentexposer/controller_test.go:390

  • The ingress name 'test-exposer-ingress-test-exposer-ingress' appears to have duplicate components. This suggests the naming logic might be concatenating the exposer name twice, which could indicate a bug in the resource naming convention.
					Name: "test-exposer-ingress-test-exposer-ingress", Namespace: testNamespace,

internal/controller/scalityuicomponentexposer/controller_test.go:392

  • The test only verifies that the ingress resource is created but doesn't validate its configuration (host, path, ingress class, etc.). Consider adding assertions to verify the ingress contains the expected configuration from the UINetworks spec.
			}, time.Second*10, time.Millisecond*250).Should(Succeed())

@MonPote MonPote merged commit 6151ff2 into main Jul 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants