Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ingress reconciliation in the ScalityUIComponentExposer by removing hardcoded service port configuration and adding proper test setup and coverage for ingress functionality.
- Removes hardcoded ServicePort "80" from ingress reconciler configuration
- Adds operator info initialization in test suite to prevent invalid label values
- Introduces comprehensive test coverage for ingress reconciliation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/scalityuicomponentexposer/ingress.go | Removes hardcoded ServicePort configuration from ingress reconciler |
| internal/controller/scalityuicomponentexposer/suite_test.go | Adds operator info initialization for test environment |
| internal/controller/scalityuicomponentexposer/controller_test.go | Adds new test case for ingress reconciliation validation |
Comments suppressed due to low confidence (2)
internal/controller/scalityuicomponentexposer/controller_test.go:390
- The ingress name 'test-exposer-ingress-test-exposer-ingress' appears to have duplicate components. This suggests the naming logic might be concatenating the exposer name twice, which could indicate a bug in the resource naming convention.
Name: "test-exposer-ingress-test-exposer-ingress", Namespace: testNamespace,
internal/controller/scalityuicomponentexposer/controller_test.go:392
- The test only verifies that the ingress resource is created but doesn't validate its configuration (host, path, ingress class, etc.). Consider adding assertions to verify the ingress contains the expected configuration from the UINetworks spec.
}, time.Second*10, time.Millisecond*250).Should(Succeed())
MonPote
approved these changes
Jul 31, 2025
MonPote
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.