UTAPI-116: Check stderr and fix deprecation warnings#1318
UTAPI-116: Check stderr and fix deprecation warnings#1318bert-e merged 6 commits intodevelopment/8.2from
Conversation
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
4de62a5 to
38badb7
Compare
| env: ${{ matrix.test.env }} | ||
| - name: Print stderr logs | ||
| run: grep -H "" *.stderr.log || true | ||
| - name: Error if stderr logs are not empty |
There was a problem hiding this comment.
Maybe a bit extreme to fail the test? IDK, just a personal feeling, it's useful to have feedback on any new stderr message, maybe we can add a continue-on-error: true so it's visible but doesn't outright fail the test if the overall test suite is successful.
There was a problem hiding this comment.
That's the idea to catch immediately a warning, so we are not surprised later.
Then if we don't plan on fixing the warning, we can filter it out from the logs (38badb7)
A continue-on-error: true could be added at any moment if there are warnings that can't be fixed to pass the tests, but ideally I'd like to fail to make sure we notice it.
And I'd like to have this in other components as well in long term
libV2/redis.js
Outdated
| * @param {Function} originalFn The function to promisify. | ||
| * @returns {Function} A function that returns a promise. | ||
| */ | ||
| function flexiblePromisify(originalFn) { |
There was a problem hiding this comment.
Is this a standard, proven function?
- if so, can you provide the ref
- if not, can you add unit tests to make sure it works as designed?
There was a problem hiding this comment.
Nothing standard, made with gemini
here are unit tests: 7a12ad2
It floods the stderr logs of cloudserver and utapi ``` (node:4634) [DEP0174] DeprecationWarning: Calling promisify on a function that returns a Promise is likely a mistake. ```
In the cleanup of functional/v2/task/testCreateSnapshot.js
7a12ad2 to
71df842
Compare
|
/approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue UTAPI-116. Goodbye bourgoismickael. The following options are set: approve |
It floods the stderr logs of cloudserver and utapi