Skip to content

WKBCH-14: Add cloudserver server-access.log and FluentBit for bucket logging#54

Merged
dvasilas merged 6 commits intomainfrom
improvement/WKBCH-14
Jan 14, 2026
Merged

WKBCH-14: Add cloudserver server-access.log and FluentBit for bucket logging#54
dvasilas merged 6 commits intomainfrom
improvement/WKBCH-14

Conversation

@dvasilas
Copy link
Copy Markdown
Contributor

  • Add a logs volume to cloudserver
  • Enable serverAccessLogs in cloudserver config when access_logging is enabled
  • Add Fluentbit service
  • Remove accountDismplayName from access_logs table (S3C-10745)

Comment on lines +180 to +196
{{ if .Features.AccessLogging.Enabled }}
"serverAccessLogs": {
"mode": "ENABLED",
"outputFile": "/logs/server-access.log",
"highWaterMarkBytes": 10485760,
"retryReopenDelayMS": 1000,
"checkFileRotationIntervalMS": 10000
},
{{ else }}
"serverAccessLogs": {
"mode": "DISABLED",
"outputFile": "/logs/server-access.log",
"highWaterMarkBytes": 10485760,
"retryReopenDelayMS": 1000,
"checkFileRotationIntervalMS": 10000
},
{{ end }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: seems like quite a duplication of code, I don't have the gotemplate syntax in mind to suggest but can we focus on only modifying mode to DISABLED/ENABLED?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to

    "serverAccessLogs": {
    {{ if .Features.AccessLogging.Enabled }}
        "mode": "ENABLED",
    {{ else }}
        "mode": "DISABLED",
    {{ end }}
        "outputFile": "/logs/server-access.log",
        "highWaterMarkBytes": 10485760,
        "retryReopenDelayMS": 1000,
        "checkFileRotationIntervalMS": 10000
    },

It seems to work, but adds two blank lines

    "serverAccessLogs": {
    
        "mode": "ENABLED",
    
        "outputFile": "/logs/server-access.log",
        "highWaterMarkBytes": 10485760,
        "retryReopenDelayMS": 1000,
        "checkFileRotationIntervalMS": 10000
    },

Cloudserver starts, so I didn't try to remove them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, it doesn't have to be pretty, as long as it's accurate. If you want to fix it you can by placing the - around the template, like this (I just placed them randomly, I can never remember exactly how they work):

    {{ if .Features.AccessLogging.Enabled -}}
        "mode": "ENABLED",
    {{ else -}}
        "mode": "DISABLED",
    {{ end -}}

But optional, at least code wise we have no duplicate now 👍

@dvasilas dvasilas force-pushed the improvement/WKBCH-14 branch from 1c726bd to 3868e93 Compare January 13, 2026 08:58
@dvasilas dvasilas force-pushed the improvement/WKBCH-14 branch from 3868e93 to 71d1f01 Compare January 14, 2026 08:56
@dvasilas dvasilas merged commit 829424e into main Jan 14, 2026
3 checks passed
@dvasilas dvasilas deleted the improvement/WKBCH-14 branch January 14, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants