WKBCH-14: Add cloudserver server-access.log and FluentBit for bucket logging#54
Merged
WKBCH-14: Add cloudserver server-access.log and FluentBit for bucket logging#54
Conversation
tmacro
approved these changes
Jan 12, 2026
tcarmet
approved these changes
Jan 12, 2026
templates/cloudserver/config-v9.json
Outdated
Comment on lines
+180
to
+196
| {{ if .Features.AccessLogging.Enabled }} | ||
| "serverAccessLogs": { | ||
| "mode": "ENABLED", | ||
| "outputFile": "/logs/server-access.log", | ||
| "highWaterMarkBytes": 10485760, | ||
| "retryReopenDelayMS": 1000, | ||
| "checkFileRotationIntervalMS": 10000 | ||
| }, | ||
| {{ else }} | ||
| "serverAccessLogs": { | ||
| "mode": "DISABLED", | ||
| "outputFile": "/logs/server-access.log", | ||
| "highWaterMarkBytes": 10485760, | ||
| "retryReopenDelayMS": 1000, | ||
| "checkFileRotationIntervalMS": 10000 | ||
| }, | ||
| {{ end }} |
Contributor
There was a problem hiding this comment.
Nit: seems like quite a duplication of code, I don't have the gotemplate syntax in mind to suggest but can we focus on only modifying mode to DISABLED/ENABLED?
Contributor
Author
There was a problem hiding this comment.
I changed it to
"serverAccessLogs": {
{{ if .Features.AccessLogging.Enabled }}
"mode": "ENABLED",
{{ else }}
"mode": "DISABLED",
{{ end }}
"outputFile": "/logs/server-access.log",
"highWaterMarkBytes": 10485760,
"retryReopenDelayMS": 1000,
"checkFileRotationIntervalMS": 10000
},
It seems to work, but adds two blank lines
"serverAccessLogs": {
"mode": "ENABLED",
"outputFile": "/logs/server-access.log",
"highWaterMarkBytes": 10485760,
"retryReopenDelayMS": 1000,
"checkFileRotationIntervalMS": 10000
},
Cloudserver starts, so I didn't try to remove them.
Contributor
There was a problem hiding this comment.
That's fine, it doesn't have to be pretty, as long as it's accurate. If you want to fix it you can by placing the - around the template, like this (I just placed them randomly, I can never remember exactly how they work):
{{ if .Features.AccessLogging.Enabled -}}
"mode": "ENABLED",
{{ else -}}
"mode": "DISABLED",
{{ end -}}
But optional, at least code wise we have no duplicate now 👍
1c726bd to
3868e93
Compare
See S3C-10745
3868e93 to
71d1f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serverAccessLogsin cloudserver config whenaccess_loggingis enabledaccountDismplayNamefromaccess_logstable (S3C-10745)