Skip to content

Conversation

@hervedombya
Copy link
Contributor

Context

Currently, users must manually create Veeam repositories in Veeam Backup & Replication after configuring ARTESCA. This PR adds form fields to enable automatic repository creation during the ISV setup, reducing manual steps and configuration errors.

What This PR Achieves

This PR adds the UI form fields that allow users to:

  • Enable automatic Veeam repository creation via a toggle
  • Configure the immutable retention period (when immutable backup is enabled)
  • Set default values when the feature is enabled

The fields are feature-flag protected and only visible for Veeam VBR.

Screenshot 2025-12-16 at 15 30 41

@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2025

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 16, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Copy link
Contributor

@ziyang-lin-404 ziyang-lin-404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have a some tests

Comment on lines 86 to 88
isVeeamVBROnly &&
isAutoRepoFeatureEnabled &&
platform.id === 'veeam-vbr'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeat veeam-vbr check

<Stack direction="horizontal">
<Controller
name="immutablePeriodDays"
control={control}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think need the error={errors.immutablePeriodDays?.message}

Comment on lines 72 to 73
| 'existing'
| 'create',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove as ...

}),
enableImmutableBackup: Joi.boolean().required().default(false),
autoCreateRepository: Joi.boolean().optional(),
immutablePeriodDays: Joi.when('autoCreateRepository', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be required(), because this value is mandatory when auto-creation is enabled.

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/4.2/feature/veeam-repository-fields with contents from feature/veeam-repository-fields
and development/4.2.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/4.2/feature/veeam-repository-fields origin/development/4.2
 git merge origin/feature/veeam-repository-fields
 # <intense conflict resolution>
 git commit
 git push -u origin w/4.2/feature/veeam-repository-fields

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Build failed

The build for commit did not succeed in branch w/4.2/feature/veeam-repository-fields

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4.1

  • ✔️ development/4.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0

Please check the status of the associated issue None.

Goodbye hervedombya.

The following options are set: approve

@bert-e bert-e merged commit f27198f into development/4.1 Dec 17, 2025
9 checks passed
@bert-e bert-e deleted the feature/veeam-repository-fields branch December 17, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants