-
Notifications
You must be signed in to change notification settings - Fork 3
add Veeam repository fields and auto-creation logic to ISVConfiguration #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
ziyang-lin-404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to have a some tests
| isVeeamVBROnly && | ||
| isAutoRepoFeatureEnabled && | ||
| platform.id === 'veeam-vbr' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeat veeam-vbr check
| <Stack direction="horizontal"> | ||
| <Controller | ||
| name="immutablePeriodDays" | ||
| control={control} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think need the error={errors.immutablePeriodDays?.message}
| | 'existing' | ||
| | 'create', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove as ...
| }), | ||
| enableImmutableBackup: Joi.boolean().required().default(false), | ||
| autoCreateRepository: Joi.boolean().optional(), | ||
| immutablePeriodDays: Joi.when('autoCreateRepository', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be required(), because this value is mandatory when auto-creation is enabled.
…ing in VeeamRepositoryFields
|
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/4.2/feature/veeam-repository-fields origin/development/4.2
git merge origin/feature/veeam-repository-fields
# <intense conflict resolution>
git commit
git push -u origin w/4.2/feature/veeam-repository-fieldsThe following options are set: approve |
Build failedThe build for commit did not succeed in branch w/4.2/feature/veeam-repository-fields The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye hervedombya. The following options are set: approve |
Context
Currently, users must manually create Veeam repositories in Veeam Backup & Replication after configuring ARTESCA. This PR adds form fields to enable automatic repository creation during the ISV setup, reducing manual steps and configuration errors.
What This PR Achieves
This PR adds the UI form fields that allow users to:
The fields are feature-flag protected and only visible for Veeam VBR.