Skip to content

Conversation

@hervedombya
Copy link
Contributor

@hervedombya hervedombya commented Dec 17, 2025

Migrate from @hapi/joi to joi and update @hookform/resolvers

Context

This PR is part of the feature plan to improve type safety and maintainability of form validation across the application. We identified type conflicts between @hookform/resolvers and @hapi/joi that required @ts-expect-error comments to suppress TypeScript errors, creating technical debt and reducing type safety.

Problem

  • @hapi/joi is deprecated and no longer maintained
  • Type incompatibility between @hookform/resolvers v2.8.8 and @hapi/joi v17.1.1 caused TypeScript errors
  • Multiple @ts-expect-error comments were used to suppress these errors, hiding potential type issues
  • The deprecated package poses long-term maintenance risks

Solution

Migrated the codebase from @hapi/joi to the actively maintained joi package and updated @hookform/resolvers to the latest version (v5.2.2) for better compatibility and type safety.

Changes

Dependencies

  • Removed: @hapi/joi (^17.1.1), @hapi/joi-date (^2.0.1), @types/hapi__joi (^17.1.8)
  • Added: joi (^18.0.1)
  • Updated: @hookform/resolvers (^2.8.8 → ^5.2.2)

Testing

Please verify form validation works correctly in:

  • ISV configuration forms (Veeam, Commvault, Veeam VBO)
  • Account creation and update forms
  • Endpoint creation form

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Copy link
Contributor

@ziyang-lin-404 ziyang-lin-404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test pass

@hervedombya
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/4.2

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 17, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4.2

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1

Please check the status of the associated issue None.

Goodbye hervedombya.

@bert-e bert-e merged commit 49da0bb into development/4.2 Dec 17, 2025
9 checks passed
@bert-e bert-e deleted the feature/update-joi branch December 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants