-
Notifications
You must be signed in to change notification settings - Fork 3
replace @hapi/joi with joi and update dependencies #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
ziyang-lin-404
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test pass
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye hervedombya. |
Migrate from @hapi/joi to joi and update @hookform/resolvers
Context
This PR is part of the feature plan to improve type safety and maintainability of form validation across the application. We identified type conflicts between
@hookform/resolversand@hapi/joithat required@ts-expect-errorcomments to suppress TypeScript errors, creating technical debt and reducing type safety.Problem
@hapi/joiis deprecated and no longer maintained@hookform/resolversv2.8.8 and@hapi/joiv17.1.1 caused TypeScript errors@ts-expect-errorcomments were used to suppress these errors, hiding potential type issuesSolution
Migrated the codebase from
@hapi/joito the actively maintainedjoipackage and updated@hookform/resolversto the latest version (v5.2.2) for better compatibility and type safety.Changes
Dependencies
@hapi/joi(^17.1.1),@hapi/joi-date(^2.0.1),@types/hapi__joi(^17.1.8)joi(^18.0.1)@hookform/resolvers(^2.8.8 → ^5.2.2)Testing
Please verify form validation works correctly in: