Skip to content

Conversation

@lutzwillek-tomtom
Copy link
Contributor

9579:

  • change default Dataset URL, not including the tailing / anymore
  • Reason is that when creating new datasources in Grafana using the "scalyr-grafana-datasource-plugin" the health check fails, in case of a taling slash.
  • old (already existing) datasources seem not affected.

@pmoran-s1 pmoran-s1 requested a review from jmakar-s1 December 18, 2024 17:23
@jmakar-s1
Copy link
Contributor

Thanks for submitting this. It's been a little while since I worked on this project, what health check is failing?

Also it looks like there is are some warnings associated with unrelated code, I will push a change to master shortly (that will need to be merged into this PR before it can be merged).

@jmakar-s1
Copy link
Contributor

jmakar-s1 commented Dec 18, 2024

@lutzwillek-tomtom Could you merge master into your PR branch? Want this change to get the Github actions to complete successfully. Once that's done I'll approve and merge the PR.

After that is done, I will also make a new release so the change can be deployed.

@lutzwillek-tomtom
Copy link
Contributor Author

lutzwillek-tomtom commented Dec 19, 2024

👍🏼 done @jmakar-s1

@lutzwillek-tomtom Could you merge master into your PR branch? Want this change to get the Github actions to complete successfully. Once that's done I'll approve and merge the PR.

After that is done, I will also make a new release so the change can be deployed.

💁🏼 Your other question regarding health check will be answered in 9579

@jmakar-s1 jmakar-s1 merged commit a8be12f into scalyr:master Dec 19, 2024
2 checks passed
@lutzwillek-tomtom lutzwillek-tomtom deleted the customer_request_9579 branch December 19, 2024 17:00
@jmakar-s1
Copy link
Contributor

@lutzwillek-tomtom New release is now available: https://github.com/scalyr/scalyr-grafana-datasource-plugin/releases/tag/3.1.4

It doesn't look like we are still publishing to the Grafana marketplace so the new plugin release can be installed manually instead.

@lutzwillek-tomtom
Copy link
Contributor Author

lutzwillek-tomtom commented Dec 19, 2024

It doesn't look like we are still publishing to the Grafana marketplace so the new plugin release can be installed manually instead.

I am aware. But this is another story, and something to solve for another day, and another customer request 9581.

Back to the issue here: I tested fine (using local plugin installation) and Grafana OSS v11.4.0 (b58701869e). Here is how I tested:

docker run -d -p 3000:3000 --name=grafana  grafana/grafana-oss
docker stop grafana
wget https://github.com/scalyr/scalyr-grafana-datasource-plugin/releases/download/3.1.4/sentinelone-dataset-datasource-3.1.4.zip
unzip sentinelone-dataset-datasource-3.1.4.zip
docker cp sentinelone-dataset-datasource grafana:/var/lib/grafana/plugins/
docker start grafana

Result:

test
version

Thanks @jmakar-s1 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants