fix: resolve #106 by avoiding shared mutable queues in ThreadedScanning

[githole]

Move input/output queues into init to ensure instance-level isolation. Did not use field(default_factory=...) because init is explicitly defined, which disables dataclass auto-init behavior.

Summary by CodeRabbit

• Refactor
  • Enhanced the scanning operations by updating the initialization process. Each scanning instance now manages its own operational state independently, promoting improved stability and more reliable performance.
  • Streamlined warning message format for improved clarity.

[coderabbitai]

Walkthrough

The changes refactor the initialization of the inputs and output attributes in the ThreadedScanning class. Instead of class-level declarations, both attributes are now instantiated within the constructor, ensuring that each instance of the class gets its own, unique queue.Queue() for input and output management. This change improves encapsulation by tying the queue instances to the lifecycle of each object.

Changes

File	Changes Summary
src/scanoss/threadedscanning.py	Moved inputs and output queue initialization from class-level variables to instance-level in the __init__ method.
src/scanoss/threadedscanning.py	Simplified warning message in queue_add method by removing "from scan..." from the print statement for empty WFP.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Caller
    participant TS as ThreadedScanning
    participant Q as Queue
    Client->>TS: Instantiate ThreadedScanning
    TS->>Q: Create new inputs queue
    TS->>Q: Create new output queue
    TS-->>Client: Return new instance with unique queues

Loading

Poem

I'm a little rabbit, coding in delight,
Hopping through queues with every byte.
Each instance blooms with its own queue charm,
No shared paths to bring alarm.
In every init, a fresh start shines bright!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8157575 and a9cd10f.

📒 Files selected for processing (1)

• src/scanoss/threadedscanning.py (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/scanoss/threadedscanning.py

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matiasdaloia]

Hi @githole, thanks for your contribution!

I've seen there are errors in our pipelines, could you please be so kind to take a look? Otherwise the PR LGTM

Thanks,

Matias

[matiasdaloia]

LGTM

[githole]

Thank you for your review!