-
Notifications
You must be signed in to change notification settings - Fork 25
fix: SP-2339 Fix wfp command loading settings file from cwd #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: SP-2339 Fix wfp command loading settings file from cwd #114
Conversation
WalkthroughThis pull request updates the software to version 1.20.7. The changelog now documents a fix for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant SettingsLoader as ScanossSettings
User->>CLI: Execute "wfp" command with settings & scan_dir
CLI->>SettingsLoader: load_json_file(settings, scan_dir)
SettingsLoader-->>CLI: Return settings (or raise ScanossSettingsError)
CLI-->>User: Display success message or error notification
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fix: SP-2339 Lint fix: SP-2339 Lint
80eb310
to
82f0ec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
12-15
: Clarify and Verify the [1.20.7] EntryThe new version entry for
[1.20.7] - 2025-04-11
clearly documents the fix addressing thewfp
command settings file loading logic. Please double-check for any accidental word duplication as flagged by static analysis—even if it might be a false positive—to ensure the text is free of typos.🧰 Tools
🪛 LanguageTool
[duplication] ~13-~13: Possible typo: you repeated a word.
Context: ...hanges... ## [1.20.7] - 2025-04-11 ### Fixed - Fixed issue with wfp command where settings f...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.md
(2 hunks)src/scanoss/__init__.py
(1 hunks)src/scanoss/cli.py
(3 hunks)src/scanoss/scanoss_settings.py
(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/scanoss/init.py
- src/scanoss/cli.py
- src/scanoss/scanoss_settings.py
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[duplication] ~13-~13: Possible typo: you repeated a word.
Context: ...hanges... ## [1.20.7] - 2025-04-11 ### Fixed - Fixed issue with wfp command where settings f...
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
CHANGELOG.md (1)
497-498
: Ensure Correctness of Reference LinksThe reference links for
[1.20.6]
and[1.20.7]
appear to follow the established URL pattern and version sequencing. Verify that these URLs correctly reflect the intended commit comparisons between versions. This consistency is crucial for users to trace changes through the history.
Summary by CodeRabbit