Open
Conversation
brunoais
force-pushed
the
add_avif_support
branch
from
aa9ea80 to
3ce9db2
Compare
From the spec, this only covers the most common format for AVIF images. I can't do more because the alternatives are speced behind a paywall. AVIF: https://aomediacodec.github.io/av1-avif/v1.1.0.html Points to HEIF: https://www.iso.org/standard/66067.html
brunoais
force-pushed
the
add_avif_support
branch
from
3ce9db2 to
1ed40d7
Compare
brunoais
commented
May 21, 2023
| height = -1 | ||
| width = -1 | ||
| data = input.read(26) | ||
| data = input.read(28) |
Author
There was a problem hiding this comment.
Added 2 bytes because I thought it would be fine to read extra 2 bytes and it would allow an extra opportunity to identify if it's AVIF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the spec, this only covers the most common format for AVIF images. I can't do more because the alternatives are speced behind a paywall.
AVIF: https://aomediacodec.github.io/av1-avif/v1.1.0.html
Points to HEIF: https://www.iso.org/standard/66067.html