Remove on create command - #110
Open
scaryrawr wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Dev Container onCreateCommand hooks that were reported to break when using DevPod, simplifying container creation across the provided devcontainer configurations.
Changes:
- Removed
onCreateCommandfrom the root, Ubuntu, and Fedora devcontainer configurations. - Deleted the corresponding
onCreateCommand.shscripts for Ubuntu and Fedora.
Show a summary per file
| File | Description |
|---|---|
.devcontainer/ubuntu/onCreateCommand.sh |
Removed Ubuntu container creation script (Rust toolchain default + bun run setup). |
.devcontainer/ubuntu/devcontainer.json |
Removed onCreateCommand reference; keeps remoteUser. |
.devcontainer/fedora/onCreateCommand.sh |
Removed Fedora container creation script (dnf RPM tooling install + Rust setup). |
.devcontainer/fedora/devcontainer.json |
Removed onCreateCommand reference; keeps remoteUser. |
.devcontainer/devcontainer.json |
Removed onCreateCommand reference for the default devcontainer config. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 1
Comment on lines
+28
to
29
| "remoteUser": "vscode" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On create command breaks in devpod