Apply clippy recommendations - #111
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies a small set of Rust/Clippy-driven cleanups across the Rust CLI (apps/sl) and core rendering library (libraries/libsl) without changing intended runtime behavior.
Changes:
- Simplifies lifetime annotations in
libslhelper code (car_text) using elided lifetimes. - Rewrites equivalent boolean/match patterns into more idiomatic Rust (
if x >= 0,if let Ok(...)). - Removes an unused
clapimport while keeping the derive/attributes intact.
Show a summary per file
| File | Description |
|---|---|
| libraries/libsl/src/print_car.rs | Removes unnecessary explicit lifetime parameters from car_text signature. |
| libraries/libsl/src/mvaddstr.rs | Replaces a negated comparison with an equivalent direct comparison for clarity. |
| apps/sl/src/main.rs | Replaces match-with-empty-Err arms with if let Ok(...) patterns in two loops. |
| apps/sl/src/cli.rs | Removes an unused clap::{command, ...} import while keeping #[command(...)] attribute usage. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.