Skip to content

Apply clippy recommendations - #111

Merged
scaryrawr merged 1 commit into
mainfrom
clippy-fixes
Jun 22, 2026
Merged

Apply clippy recommendations#111
scaryrawr merged 1 commit into
mainfrom
clippy-fixes

Conversation

@scaryrawr

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 21, 2026 00:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a small set of Rust/Clippy-driven cleanups across the Rust CLI (apps/sl) and core rendering library (libraries/libsl) without changing intended runtime behavior.

Changes:

  • Simplifies lifetime annotations in libsl helper code (car_text) using elided lifetimes.
  • Rewrites equivalent boolean/match patterns into more idiomatic Rust (if x >= 0, if let Ok(...)).
  • Removes an unused clap import while keeping the derive/attributes intact.
Show a summary per file
File Description
libraries/libsl/src/print_car.rs Removes unnecessary explicit lifetime parameters from car_text signature.
libraries/libsl/src/mvaddstr.rs Replaces a negated comparison with an equivalent direct comparison for clarity.
apps/sl/src/main.rs Replaces match-with-empty-Err arms with if let Ok(...) patterns in two loops.
apps/sl/src/cli.rs Removes an unused clap::{command, ...} import while keeping #[command(...)] attribute usage.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 0

@scaryrawr
scaryrawr merged commit 3d2fe0c into main Jun 22, 2026
11 checks passed
@scaryrawr
scaryrawr deleted the clippy-fixes branch June 22, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants