Surface MLX feature parity in user-facing docs - #321
Merged
Conversation
Post-epic-#278 discoverability pass: the AGENTS.md map annotation still said GG-only; the EEGLAB guide never mentioned the MLX export path; the backends table row and README undersold the now-complete MLX surface. Docs only.
The export-validation claim now states float32 precision rather than byte comparison (only comp_list is exact), and the test that seeded the overclaim is renamed to match its actual assertion; the backends table row returns to terse form with the parity statement moved to prose that names the wrapper-only from_params_file caveat (#313); MIR is spelled out on first use in the README; the stale GG-only class one-liner in mlx core is corrected. Export suite 12 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discoverability follow-up to epic #278 (the epic updated every doc it touched; these are the four spots it did not):
amicaoutdirectly, no torch round trip) -- the guide previously never mentioned MLX, though MLX users' downstream is EEGLAB.Docs only; claims cross-checked against the epic's landed surface (write_amica_output byte-comparison tests, the differences-page backend table).