Basic Implementation of User Listening History Download #447
Open
CosmicSage wants to merge 6 commits intoscdl-org:masterfrom
Open
Basic Implementation of User Listening History Download #447CosmicSage wants to merge 6 commits intoscdl-org:masterfrom
CosmicSage wants to merge 6 commits intoscdl-org:masterfrom
Conversation
Author
|
Here's the screenshot of results You must copy the main soundcloud.py and resource/history.py from soundcloud api wrapper fork to site-packages to test this locally as @7x11x13 hasn't merged/released my code yet/ |
Author
|
Also can I get mordertor access I will take care I swear..🙏 @7x11x13 @flyingrub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I successfully add listening history download to scdl. In many of my attempts to download I have always got the desired result .
My Code is very non-invasive to the codebase almost like blue in sky, as you might expect.
Ok so the test may fail because @7x11x13 of soundcloud.py API wrapper hasn't yet merged my work of adding history endpoint to the wrapper whose PR you can see here
So to test on your computer you can check my fork and copy paste two files to your site-packages (that's what I did in development)
Look if this gets merged I will make it cleaner and enhance this new feature as well, as the api returns few more data fields which are not considered while downloading.
Hope you like it. Please merge fast
Thank you