Merged
Conversation
This was referenced Jan 30, 2026
…Spinemetadata and MoveInstanceVR from sciview to manvr3d
…passing manvr3d to CellTrackingBase
…hash. Add default arguments for colorizer/color mode
… Manvr3dMain: Cap updateQueue to 100 entries to prevent memory leaks
…g logs less verbose
skalarproduktraum
requested changes
Feb 26, 2026
Member
skalarproduktraum
left a comment
skalarproduktraum
left a comment
There was a problem hiding this comment.
I've left a few remarks, but in general, this looks good 👍
Please take care that the package paths are correct, e.g. graphics.scenery.manvr3d instead of just manvr3d.
skalarproduktraum
requested changes
Mar 5, 2026
Member
skalarproduktraum
left a comment
skalarproduktraum
left a comment
There was a problem hiding this comment.
One small thing left, then good to go 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a lot of manvr3d code and reorganizes classes and methods between manvr3d, sciview and scenery. PR siblings are scenerygraphics/scenery#821 and scenerygraphics/sciview#635.