Open
Conversation
Add quite a bit more testing to the multiple databases feature, especially around configuraiton, definition, and statement routing. Introduce a new FakeAdapter class to let us test against a non-Postgres adapter without having a dependency on any of the various actual adapters out there (we love you, but we don't want a cyclic dependency!) - Rework the new README changes to somewhat closer match the cheeky style of the original. - Fix array handling for migrations_paths. Rails lets us define a `:migrations_paths` key that can be an array or a string in `database.yml`, and we previously ignored the possibility of that being an array. New functionality matches what Rails does. Introduce configurable view paths! I'm hopeful that a lot of folks will be happy with this. You can configure this with `views_paths` in `database.yml` and it should default similarly to how migrations do to `db/<database_name>_views/` for non-default databases. Fix: #291 Fix: #380 Fix: #261
3 tasks
Contributor
Author
|
@dnamsons @leoplct @joshfester Would you like to give this a shot for the multiple dbs and/or adapters implementation? @sullerandras @smdern @coding-chimp @MarcReniu @tomasc @huarmenta @vladimirtemnikov @nathanpalmer @jdno @shageman @hlascelles and probably others, this may also get us closer to some of the various Engines and configurable db/views paths needs so I'd love to get input on that as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quite a bit more testing to the multiple databases feature, especially
around configuraiton, definition, and statement routing. Introduce a new
FakeAdapter class to let us test against a non-Postgres adapter without having a
dependency on any of the various actual adapters out there (we love you, but we
don't want a cyclic dependency!)
original.
:migrations_pathskey that can be an array or a string indatabase.yml,and we previously ignored the possibility of that being an array. New
functionality matches what Rails does.
Introduce configurable view paths! I'm hopeful that a lot of folks will be happy
with this. You can configure this with
views_pathsindatabase.ymland itshould default similarly to how migrations do to
db/<database_name>_views/fornon-default databases.
Fix: #291
Fix: #380
Fix: #261
Resolves: #402
Closes: #451