fix(ml-cellar): add comment for error message#18
Merged
scepter914 merged 2 commits intomainfrom Jan 17, 2026
Merged
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR enhances error messages across multiple ml-cellar commands by adding helpful guidance for users when errors occur. The changes provide additional context and actionable suggestions when git operations fail or configuration issues are detected.
Changes:
- Enhanced error messages with user guidance for manual troubleshooting
- Updated error messages in git-related operations (init, clone, push, materialize)
- Improved configuration-related error messages
Reviewed changes
Copilot reviewed 1 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rack.rs | Added guidance for config.toml not found error |
| src/bin/ml-cellar/push.rs | Added manual check suggestions for git push failures |
| src/bin/ml-cellar/materialize.rs | Added manual check suggestions for git lfs pull failures |
| src/bin/ml-cellar/init.rs | Added manual check suggestions for git init and branch operations |
| src/bin/ml-cellar/docs.rs | Reformatted documentation configuration error message |
| src/bin/ml-cellar/clone.rs | Added manual check suggestions for git clone failures |
| src/bin/ml-cellar/check.rs | Reformatted version format validation error message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For users, this PR add error message for each command.
Change point