fix(ml-cellar): add MLBin struct#20
Merged
scepter914 merged 11 commits intomainfrom Jan 18, 2026
Merged
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces an MLBin struct to simplify handling of ML-bin paths throughout the codebase. The changes refactor the configuration structure by renaming repository.rs to cellar.rs with a more descriptive CellarConfig name. Additionally, comprehensive documentation has been added across all modules and functions.
Changes:
- Added new
MLBinstruct for centralized ML-bin path management with factory methods - Renamed
RepositoryConfigtoCellarConfigand moved fromrepository.rstocellar.rs - Enhanced all functions and CLI commands with detailed documentation
- Refactored
ProjectConfig::is_valid_version()to accept string parameters instead of extracting from paths
Reviewed changes
Copilot reviewed 5 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/repository.rs | Deleted - configuration moved to cellar.rs |
| src/cellar.rs | New file with renamed CellarConfig and load_cellar_config function |
| src/ml_bin.rs | New file containing MLBin struct for ML-bin path handling |
| src/lib.rs | Updated module exports to reflect new structure |
| src/rack.rs | Added documentation, converted to absolute paths, refactored ProjectConfig methods |
| src/bin/ml-cellar/check.rs | Refactored to use MLBin struct and both cellar/rack configs |
| src/bin/ml-cellar/docs.rs | Updated function names and variable names for consistency |
| src/bin/ml-cellar/init.rs | Updated to use CellarConfig instead of RepositoryConfig |
| src/bin/ml-cellar/main.rs | Added comprehensive CLI documentation |
| src/bin/ml-cellar/rack.rs | Added function documentation |
| src/bin/ml-cellar/push.rs | Added function documentation |
| src/bin/ml-cellar/materialize.rs | Added function documentation |
| src/bin/ml-cellar/clone.rs | Added function documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: scepter914 <scepter914@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(ml-cellar): add MLBin struct
Change point
This PR add MLBin struct to handle easily for the path.