Skip to content

fix(ml-cellar): add MLBin struct#20

Merged
scepter914 merged 11 commits intomainfrom
fix/ml-bin
Jan 18, 2026
Merged

fix(ml-cellar): add MLBin struct#20
scepter914 merged 11 commits intomainfrom
fix/ml-bin

Conversation

@scepter914
Copy link
Copy Markdown
Owner

@scepter914 scepter914 commented Jan 18, 2026

Summary

fix(ml-cellar): add MLBin struct

Change point

  • fix(ml-cellar): add MLBin struct

This PR add MLBin struct to handle easily for the path.

  • chore(ml-cellar): add docstring

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an MLBin struct to simplify handling of ML-bin paths throughout the codebase. The changes refactor the configuration structure by renaming repository.rs to cellar.rs with a more descriptive CellarConfig name. Additionally, comprehensive documentation has been added across all modules and functions.

Changes:

  • Added new MLBin struct for centralized ML-bin path management with factory methods
  • Renamed RepositoryConfig to CellarConfig and moved from repository.rs to cellar.rs
  • Enhanced all functions and CLI commands with detailed documentation
  • Refactored ProjectConfig::is_valid_version() to accept string parameters instead of extracting from paths

Reviewed changes

Copilot reviewed 5 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/repository.rs Deleted - configuration moved to cellar.rs
src/cellar.rs New file with renamed CellarConfig and load_cellar_config function
src/ml_bin.rs New file containing MLBin struct for ML-bin path handling
src/lib.rs Updated module exports to reflect new structure
src/rack.rs Added documentation, converted to absolute paths, refactored ProjectConfig methods
src/bin/ml-cellar/check.rs Refactored to use MLBin struct and both cellar/rack configs
src/bin/ml-cellar/docs.rs Updated function names and variable names for consistency
src/bin/ml-cellar/init.rs Updated to use CellarConfig instead of RepositoryConfig
src/bin/ml-cellar/main.rs Added comprehensive CLI documentation
src/bin/ml-cellar/rack.rs Added function documentation
src/bin/ml-cellar/push.rs Added function documentation
src/bin/ml-cellar/materialize.rs Added function documentation
src/bin/ml-cellar/clone.rs Added function documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ml_bin.rs
Comment thread src/ml_bin.rs
Comment thread src/ml_bin.rs
Comment thread src/ml_bin.rs
Comment thread src/rack.rs
Comment thread src/cellar.rs
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 merged commit dbb081a into main Jan 18, 2026
1 check passed
@scepter914 scepter914 deleted the fix/ml-bin branch January 18, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants