Fix uclamp support #113
Open
Fix uclamp support #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Now tested |
douglas-raillard-arm
changed the title
douglas-raillard-arm
force-pushed
the
uclamp-reset
branch
2 times, most recently
from
a226977 to
d38b9e4
Compare
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 24, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 24, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 24, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 24, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 25, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Feb 25, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to douglas-raillard-arm/lisa
that referenced
this pull request
Mar 2, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
pushed a commit
to ARM-software/lisa
that referenced
this pull request
Mar 3, 2021
Since the uclamp support fixes [1] are necessary to use taskgroup and util clamp in conjunction in rt-app (which is now the default for test workloads), ensure we get a fixed version while waiting for the review of the fix. [1] scheduler-tools/rt-app#113
douglas-raillard-arm
force-pushed
the
uclamp-reset
branch
from
d38b9e4 to
82b4b47
Compare
douglas-raillard-arm
force-pushed
the
uclamp-reset
branch
from
82b4b47 to
15d452b
Compare
cpu_set_t allocated dynamically with CPU_ALLOC need to be manipulated with CPU_*_S() family of macro, otherwise it will be assumed that the size is equal to sizeof(cpu_set_t), leading to undefined behaviours.
Since the use of the dynamique API does not bring a greater range of allowed CPUs in the current state, use the fixed-size API in order to remove reliance on invalid assumptions about the size of the dynamique cpu_set_t value.
Detect up to a configurable number of CPUs, independently from what the libc defaults to.
Free cpuset_str in __shutdown.
douglas-raillard-arm
force-pushed
the
uclamp-reset
branch
from
15d452b to
c0c1cc9
Compare
Since special value (u32)-1 removes the clamp for the task in the kernel, free -1 special value from rt-app internals so that the user can make use of it. Replace it with -2 instead.
Duplicate sched_data for each thread to allow modifying it to keep track of the current thread sched state.
The struct sched_param passed to sched_setattr() for uclamp needs to
have a valid policy and priority set.
Currently, sched_data->prio is set to a special value
THREAD_PRIORITY_UNCHANGED when the phase does not declare a specific
priority, and sched_data->policy is set to "same". This is problematic
as the kernel expects a valid policy and priority. We currently pass
the special values to the kernel, which makes the syscall fail.
Fix that by maintaining a valid policy and priority in
thread_data_t->curr_sched_data->{policy,prio} and using it where
appropriate.
douglas-raillard-arm
force-pushed
the
uclamp-reset
branch
from
c0c1cc9 to
b30f5a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing -1 to sched_setattr() to reset the clamp
fixes #112
Also fixes uclamp updates when the current phase does not specify a policy/priority.
fixes #114
For some (not yet investigated) reasons, this also fixes:
#115