Update build documentation #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numactl has switched to cmake and therefore the build instructions had to be updated. Other minor adaptions were done, too. numactl when used by file path needs to be in the numactl directory, so that was updated. Furthermore the git clone was removed to be in line with the other github link. Signed-off-by: Christian Loehle <[email protected]>
After checking json-c and numactl repo, it seems that json-c moved to cmake and not numactl |
| @@ -37,8 +37,7 @@ cross-compile json-c and build both static and shared libraries for aarch64: | |||
|
|
|||
| export ac_cv_func_malloc_0_nonnull=yes | |||
| export ac_cv_func_realloc_0_nonnull=yes | |||
| ./autogen.sh | |||
| ./configure --host=aarch64-linux-gnu --enable-shared --enable-static | |||
| cmake -DCMAKE_C_COMPILER=aarch64-linux-gnu-gcc . | |||
There was a problem hiding this comment.
with cmake, we usually prefer to build in a dedicated directory:
#cmake -B json-c-build -DCMAKE_C_COMPILER=aarch64-linux-gnu-gcc
#cmake --build json-c-build/
| @@ -74,7 +73,7 @@ cross-compile a static rt-app for aarch64, using your own json-c and/or numactl | |||
| export ac_cv_lib_numa_numa_available=yes | |||
|
|
|||
| ./autogen.sh | |||
| ./configure --host=aarch64-linux-gnu LDFLAGS="-L<absolute path to json repo> -L<absolute path to numactl repo>" CFLAGS="-I<path to parent of json-c repo> -I<path to parent of numactl repo>" | |||
| ./configure --host=aarch64-linux-gnu LDFLAGS="-L<absolute path to json repo> -L<absolute path to numactl repo>" CFLAGS="-I<path to parent of json-c repo> -I<path to numactl repo>" | |||
There was a problem hiding this comment.
./configure --host=aarch64-linux-gnu LDFLAGS="-L/json-c-build/ -L" CFLAGS="-I -I"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numactl has switched to cmake and therefore the build instructions had to be updated. Other minor adaptions were done, too.
numactl when used by file path needs to be in the numactl directory, so that was updated. Furthermore the git clone was removed to be in line with the other github link.