Added hyperbolic numeric builtins.#28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements 5 hyperbolic numeric builtin functions (acosh, asinh, atanh, cosh, sinh) following the existing WGSL specification, completing issue #14. Each function follows the established pattern in the codebase with trait definitions, free function wrappers, and implementations for both scalar f32 and vector types (Vec2f, Vec3f, Vec4f).
Key changes:
- Added 5 new trait/function pairs for hyperbolic functions with full documentation
- Implemented each function for scalar
f32and all vector types - Added sanity tests for all 5 functions
- Updated the documentation table to mark these functions as implemented
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #14. 1. Added 5 new trait/function pairs following the existing `tanh` pattern 2. Each function has: - A trait (e.g., `NumericBuiltinAcosh`) - A free function (e.g., `pub fn acosh<T: NumericBuiltinAcosh>(e: T) -> T`) - Implementations for `f32`, `Vec2f`, `Vec3f`, `Vec4f` 3. Added 5 sanity tests (`sanity_acosh`, `sanity_asinh`, `sanity_atanh`, `sanity_cosh`, `sanity_sinh`) 4. Updated doc comment table to mark all 5 functions as implemented (`x`)
schell
force-pushed
the
feat/numeric_builtin_hyperbolics
branch
from
787fb0d to
4cc311d
Compare
schell
added a commit
that referenced
this pull request
May 29, 2026
Fixes #14. 1. Added 5 new trait/function pairs following the existing `tanh` pattern 2. Each function has: - A trait (e.g., `NumericBuiltinAcosh`) - A free function (e.g., `pub fn acosh<T: NumericBuiltinAcosh>(e: T) -> T`) - Implementations for `f32`, `Vec2f`, `Vec3f`, `Vec4f` 3. Added 5 sanity tests (`sanity_acosh`, `sanity_asinh`, `sanity_atanh`, `sanity_cosh`, `sanity_sinh`) 4. Updated doc comment table to mark all 5 functions as implemented (`x`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14.
tanhpatternNumericBuiltinAcosh)pub fn acosh<T: NumericBuiltinAcosh>(e: T) -> T)f32,Vec2f,Vec3f,Vec4fsanity_acosh,sanity_asinh,sanity_atanh,sanity_cosh,sanity_sinh)x)