You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removing unused imports is great, but the rest amounts to a change in code style. Can we limit this to just the unused imports, please?
i used intellij's Optimize Imports - removed the implicit changes (e.g. rearangements of the imports) now
maybe some gradle plugin like Checkstyle would make sense to enforce a common code style?
IntelliJ can be configured to refer to the same style-config, so Strg+Alt+L (or Strg-Alt-O) will arrange the code the same.
Or, more general, one can add a pre-commit-hook to apply the checkstyle autofix on changed files.
This PR still has more than just removing unused imports. I don't think this is very important, so perhaps better to skip it rather than put a lot of effort into it? I would have removed the unused imports myself if I thought it was important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pure code cleanup
this MR is based on MR #251