WIP: Split into subprojects - core and extras.#28
WIP: Split into subprojects - core and extras.#28alexanderkjeldaas wants to merge 5 commits intoschibsted:masterfrom
Conversation
|
Yes, I think this looks entirely reasonable. I need to review the details in how the gradle files were split, but the rest looks very nice. Regarding how to package the functions you can look at the experimental module: https://github.com/schibsted/jslt/blob/master/src/main/java/com/schibsted/spt/data/jslt/impl/ExperimentalModule.java Someone wanting to use the module can pass it to the parser with this method https://github.com/schibsted/jslt/blob/master/src/main/java/com/schibsted/spt/data/jslt/Parser.java#L176 See the experimental module for the use of URIs to name modules. The other open PR by @pratikpparikh has some service provider interface (SPI) concept in it that I think could be relevant. You can look into that if you want, or if you prefer we can just do the split and the new module first, and consider the SPI issue later. |
|
@alexanderkjeldaas Are you still working on this? |
|
@larsga if @alexanderkjeldaas is not working on it can we just do it between us? |
|
The task itself is trivial to do. But if there isn't anything to add in the non-core part then we might as well wait. :-) |
Not for merging, but is this split reasonable?