Error handling for SyncSession #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raises EventMachine::FtpClient::Error if anything goes wrong. Response is available in the exception object.
Open
added 6 commits
March 19, 2015 11:40
If control connection completed before data connection, data connection demeed the control response uncompleted, since the completion of control response was creation a new response in @response (which is what the data connection callback was later checking).
@data_connection was always nil in the callback since the order of clearing was wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises EventMachine::FtpClient::Error if anything goes wrong.
Response is available in the exception object.
No handling included for the asynchronous session.