If the domain does not match the hostmap, it should not bail out and thr... #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No cookies should be present
No cookies should be present
…throw an exception. It should fall back to the default locale
Test fixes
…nto invalid-hostmap-logic
|
I'm not convinced by this. If a route is restricted to another host and consequentially does not exist on the current host, then a 404 seems like the logical response in such a case. |
|
Any thoughts on changing this to be a configuration option? As redirect_to_host is not always a valid option. Just to note the error throws Throws "[1/2] ResourceNotFoundException: Resource corresponding to pattern "/" not found for locale ""." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the domain does not match the hostmap, it should not bail out and throw an exception.
It should fall back to the default locale.