Setting @Ignore to fully ignore the string

Resources/doc/usage.rst

@@ -78,6 +78,30 @@ translations in PHP code, the ``@Desc`` annotation:
 You can place the doc comment anywhere in the method call chain or directly 
 before the key.
 
+Ignoring messages
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+You might have some messages that you would like to ignore in your Forms or Controllers.
+You can use the @Ignore annotation for this:
+
+.. code-block :: php
+
+    <?php
+
+    // Controller.php
+    /** @Ignore */
+    $this->translator->trans('text.ignore_me')
+
+.. code-block :: php
+
+    <?php
+
+    // FormType.php
+    $builder->add('field_with_ignored_label', 'text', array(
+        'label' => /** @Ignore */ 'form.ignored'
+    ));
+
+
 Extracting Translation Messages
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 This bundle automatically supports extracting messages from the following 

Tests/Translation/Dumper/PhpDumperTest.php

@@ -48,6 +48,6 @@ protected function getOutput($key)
             throw new InvalidArgumentException(sprintf('There is no output for key "%s".', $key));
         }
 
-        return file_get_contents($file);
+        return str_replace("\r\n", "\n", file_get_contents($file));
     }
 }

Tests/Translation/Dumper/XliffDumperTest.php

@@ -124,6 +124,6 @@ protected function getOutput($key)
 //         $doc = \DOMDocument::load($file);
 //         $this->assertTrue($doc->schemaValidate(__DIR__.'/../../../Resources/schema/xliff-core-1.2-strict.xsd'));
 
-        return file_get_contents($file);
+        return str_replace("\r\n", "\n", file_get_contents($file));
     }
 }

Tests/Translation/Dumper/YamlDumperTest.php

@@ -48,6 +48,6 @@ protected function getOutput($key)
             throw new InvalidArgumentException(sprintf('There is no output for key "%s".', $key));
         }
 
-        return file_get_contents($file);
+        return str_replace("\r\n", "\n", file_get_contents($file));
     }
 }

Tests/Translation/Extractor/File/AuthenticationMessagesExtractorTest.php

@@ -31,15 +31,19 @@ public function testExtract()
 
         $message = new Message('security.authentication_error.foo', 'authentication');
         $message->setDesc('%foo% is invalid.');
-        $message->addSource(new FileSource(__DIR__.'/Fixture/MyAuthException.php', 31));
+        $message->addSource(new FileSource(__DIR__.'/Fixture/MyAuthException.php', 35));
         $expected->add($message);
 
         $message = new Message('security.authentication_error.bar', 'authentication');
         $message->setDesc('An authentication error occurred.');
-        $message->addSource(new FileSource(__DIR__.'/Fixture/MyAuthException.php', 35));
+        $message->addSource(new FileSource(__DIR__.'/Fixture/MyAuthException.php', 39));
         $expected->add($message);
 
-        $this->assertEquals($expected, $this->extract('MyAuthException.php'));
+        $extracted = $this->extract('MyAuthException.php');
+
+        $this->assertFalse($extracted->getDomains()['authentication']->has('security.authentication_error.ignored'));
+
+        $this->assertEquals($expected, $extracted);
     }
 
     protected function getDefaultExtractor()

Tests/Translation/Extractor/File/Fixture/Controller.php

@@ -81,4 +81,10 @@ public function assignToVar()
         /** @Desc("The var %foo% should be assigned.") */
         return $this->translator->trans('text.var.assign', array('%foo%' => 'fooVar'));
     }
+
+    public function ignoredAction()
+    {
+        $this->translator->trans(/** @Ignore */ 'text.ignored');
+    }
 }
+

Tests/Translation/Extractor/File/Fixture/MyAuthException.php

@@ -26,6 +26,10 @@ class MyAuthException extends AuthenticationException
 
     public function getMessageKey()
     {
+
+        /** @Ignore */
+        $ignored = 'security.authentication_error.ignored';
+
         if (!empty($this->foo)) {
             /** @Desc("%foo% is invalid.") */
             return 'security.authentication_error.foo';

Tests/Translation/Extractor/File/Fixture/MyFormType.php

@@ -78,5 +78,8 @@ public function buildForm(FormBuilder $builder, array $options)
         $builder->add('dueDate', 'date', array(
                 'empty_value' => array('year' => 'form.dueDate.empty.year', 'month' => 'form.dueDate.empty.month', 'day'=>'form.dueDate.empty.day')
         ));
+        $builder->add('field_with_ignored_label', 'text', array(
+                'label' => /** @Ignore */ 'form.ignored'
+            ));
     }
 }

Tests/Translation/Extractor/File/FormExtractorTest.php

@@ -79,6 +79,16 @@ public function testExtract()
         $expected = new MessageCatalogue();
         $path = __DIR__.'/Fixture/MyFormType.php';
 
+        $message = new Message('form.label.firstname');
+        $message->setDesc(null);
+        $message->addSource(new FileSource($path, 30));
+        $expected->add($message);
+
+        $message = new Message('form.label.lastname');
+        $message->setDesc('Lastname');
+        $message->addSource(new FileSource($path, 33));
+        $expected->add($message);
+
         // Symfony >= 3.0 switch the default behavior of the choice field following a BC break introduced in 2.7
         // @see https://github.com/symfony/symfony/blob/master/UPGRADE-3.0.md#choices_as_values
         if (Kernel::VERSION_ID >= 30000) {
@@ -94,15 +104,6 @@ public function testExtract()
         $message->addSource(new FileSource($path, 37));
         $expected->add($message);
 
-        $message = new Message('form.label.lastname');
-        $message->setDesc('Lastname');
-        $message->addSource(new FileSource($path, 33));
-        $expected->add($message);
-
-        $message = new Message('form.label.firstname');
-        $message->addSource(new FileSource($path, 30));
-        $expected->add($message);
-
         $message = new Message('form.label.password');
         $message->addSource(new FileSource($path, 42));
         $expected->add($message);
@@ -112,6 +113,11 @@ public function testExtract()
         $message->addSource(new FileSource($path, 45));
         $expected->add($message);
 
+        $message = new Message('form.error.password_mismatch', 'validators');
+        $message->setDesc('The entered passwords do not match');
+        $message->addSource(new FileSource($path, 47));
+        $expected->add($message);
+
         $message = new Message('form.label.street', 'address');
         $message->setDesc('Street');
         $message->addSource(new FileSource($path, 50));
@@ -122,15 +128,6 @@ public function testExtract()
         $message->addSource(new FileSource($path, 55));
         $expected->add($message);
 
-        $message = new Message('form.error.password_mismatch', 'validators');
-        $message->setDesc('The entered passwords do not match');
-        $message->addSource(new FileSource($path, 47));
-        $expected->add($message);
-
-        $message = new Message('form.label.created');
-        $message->addSource(new FileSource($path, 75));
-        $expected->add($message);
-
         $message = new Message('field.with.placeholder');
         $message->addSource(new FileSource($path, 59));
         $expected->add($message);
@@ -145,6 +142,18 @@ public function testExtract()
         $message->addSource(new FileSource($path, 64));
         $expected->add($message);
 
+        $message = new Message('form.choice.choice_as_values.label.foo');
+        $message->addSource(new FileSource($path, 68));
+        $expected->add($message);
+
+        $message = new Message('form.choice.choice_as_values.label.bar');
+        $message->addSource(new FileSource($path, 69));
+        $expected->add($message);
+
+        $message = new Message('form.label.created');
+        $message->addSource(new FileSource($path, 75));
+        $expected->add($message);
+
         $message = new Message('form.dueDate.empty.year');
         $message->addSource(new FileSource($path, 79));
         $expected->add($message);
@@ -157,15 +166,13 @@ public function testExtract()
         $message->addSource(new FileSource($path, 79));
         $expected->add($message);
 
-        $message = new Message('form.choice.choice_as_values.label.foo');
-        $message->addSource(new FileSource($path, 68));
-        $expected->add($message);
+        $extracted = $this->extract('MyFormType.php');
 
-        $message = new Message('form.choice.choice_as_values.label.bar');
-        $message->addSource(new FileSource($path, 69));
-        $expected->add($message);
+        // Test ignore
+        $this->assertFalse($extracted->getDomains()['messages']->has('form.ignored'));
+
+        $this->assertEquals($expected, $extracted);
 
-        $this->assertEquals($expected, $this->extract('MyFormType.php'));
     }
 
     /**

Tests/Translation/Extractor/FileExtractorTest.php

@@ -88,7 +88,7 @@ public function testExtractWithSimpleTestFixtures()
         asort($expected);
         asort($actual);
 
-        $this->assertEquals($expected, $actual);
+        $this->assertEquals($expected, str_replace('/', '\\', $actual));
     }
 
     private function extract($directory)

Translation/Extractor/File/DefaultPhpFileExtractor.php

@@ -133,10 +133,12 @@ public function enterNode(Node $node)
             }
         }
 
+        if ($ignore) {
+            return;
+        }
+
         if (!$node->args[0]->value instanceof String_) {
-            if ($ignore) {
-                return;
-            }
+
 
             $message = sprintf('Can only extract the translation id from a scalar string, but got "%s". Please refactor your code to make it extractable, or add the doc comment /** @Ignore */ to this code element (in %s on line %d).', get_class($node->args[0]->value), $this->file, $node->args[0]->value->getLine());
 
@@ -152,10 +154,8 @@ public function enterNode(Node $node)
 
         $index = $this->methodsToExtractFrom[strtolower($node->name)];
         if (isset($node->args[$index])) {
+
             if (!$node->args[$index]->value instanceof String_) {
-                if ($ignore) {
-                    return;
-                }
 
                 $message = sprintf('Can only extract the translation domain from a scalar string, but got "%s". Please refactor your code to make it extractable, or add the doc comment /** @Ignore */ to this code element (in %s on line %d).', get_class($node->args[0]->value), $this->file, $node->args[0]->value->getLine());
 

Translation/Extractor/File/FormExtractor.php

@@ -364,10 +364,11 @@ private function parseItem($item, $domain = null)
         // check if the value is explicitly set to false => e.g. for FormField that should be rendered without label
         $ignore = $ignore || !$item->value instanceof Node\Scalar\String_ || $item->value->value == false;
 
+        if ($ignore) {
+            return;
+        }
+
         if (!$item->value instanceof Node\Scalar\String_ && !$item->value instanceof Node\Scalar\LNumber) {
-            if ($ignore) {
-                return;
-            }
 
             $message = sprintf('Unable to extract translation id for form label/title/placeholder from non-string values, but got "%s" in %s on line %d. Please refactor your code to pass a string, or add "/** @Ignore */".', get_class($item->value), $this->file, $item->value->getLine());
             if ($this->logger) {