Domain annotation form extractor #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2014 16:35
…, "messages_two"}) in FormExtractor to handle multiuse of form type with diferent translation domain
|
This is a bit related to #235. |
|
Hello, I like this PR, Could you redo the tests as a separate form type / test? That way each test doesn't modify lines of source files of previous tests etc. Makes merging multiple PRs easier. |
|
Its also related to #276 |
|
Hello, I will extract my test this week. |
|
Sorry, I was not notified when you pushed to this PR. I like it. Thank you. I have a suggestion: Lets merge the annotations to one Otherwise Im happy to merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suport for @Domain{"domain"} and @domains({"domain_one", "domain_two"}) on FormExtractor.
I use these annotations for FormType use in admin and frontend with different domain translation.