Remove kernel.root_dir usages #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deguif
force-pushed
the
remove-kernel-root-dir
branch
from
c1d0e62 to
ff64de0
Compare
deguif
force-pushed
the
remove-kernel-root-dir
branch
from
ff64de0 to
6269fb6
Compare
|
I just rebased this one. It should be ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
kernel.root_dirand always usekernel.project_diras always available as per symfony versions requirements.This allows to drop the requirement on
symfony/expression-languagewhich was introduced for theexpressionargument in dependency injection