Add type-hints on private / final methods / properties#610
Merged
goetas merged 1 commit intoschmittjoh:masterfrom Feb 9, 2025
Merged
Add type-hints on private / final methods / properties#610goetas merged 1 commit intoschmittjoh:masterfrom
goetas merged 1 commit intoschmittjoh:masterfrom
Conversation
Contributor
deguif
commented
Feb 9, 2025
deguif
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes/no |
| Fixed tickets | |
| License | Apache2 |
deguif
force-pushed
the
review-private-final-type-hints
branch
3 times, most recently
from
5c05ec4 to
d30b4cb
Compare
deguif
force-pushed
the
review-private-final-type-hints
branch
from
d30b4cb to
6584336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.