Fixed Twig 3.x deprecations #621
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Not passing an instance of "TwigFilter" when creating a "replace" filter of type "Twig\Node\Expression\FilterExpression" is deprecated." deprecation warning
adamwojs
commented
Feb 20, 2025
|
|
||
| // wrap the default node in a |replace filter | ||
| $defaultNode = new FilterExpression( | ||
| $arguments[0], | ||
| new ConstantExpression('replace', $lineno), | ||
| new Node([$wrappingNodeArguments[0]]), | ||
| $env->getFilter('replace'), |
There was a problem hiding this comment.
Twig\Environment::getFilter method is considered as @internal, however I didn't find better way to retrieve TwigFilter instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the following Twig 3.x deprecations in triggered by
\JMS\TranslationBundle\Twig\DefaultApplyingNodeVisitor:PR is still work in progress.
Todos