#1297: Fix deserialization of doctrine entity with null identifier#1299
Open
Toilal wants to merge 2 commits into
Open
#1297: Fix deserialization of doctrine entity with null identifier#1299Toilal wants to merge 2 commits into
Toilal wants to merge 2 commits into
Conversation
Toilal
commented
Mar 17, 2021
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1297 |
| License | MIT |
Collaborator
|
hmm, this sounds strange to me... the Something like $authorFetched = $constructor->construct($this->visitor, $class, ['id1' => null, 'id2' => 123 ], $type, $this->context); |
d7b9767 to
b8303f9
Compare
Author
|
@goetas I don't have this use case in my current projects, so I can't really test composite primary keys for now. According to this issue doctrine/orm#6647, Doctrine doesn't support null fields in a composite primary key. So we probably want to skip find invocation when a single field is null. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.