Skip to content

Capture tshark errors and display as warnings - #65

Open
eprochasson wants to merge 2 commits into
schollz:masterfrom
eprochasson:ep_io_fix
Open

Capture tshark errors and display as warnings#65
eprochasson wants to merge 2 commits into
schollz:masterfrom
eprochasson:ep_io_fix

Conversation

@eprochasson

Copy link
Copy Markdown

As discussed in issue #64 .

This PR proposes the following:

  • capture the stderr output of tshark and display it as a warning (instead of silently ignoring it)
  • use proper temporary file / directory mechanism for the output of tshark, to avoid collisions.

It has been written with Python 2 and 3 in mind, however I only tested it with Python 3.

I eventually chose not to move the output to logging, as it's a pretty heavy change that will also break compatibility.

Moved fixed tshark dump to securely generated temporary file to avoid collision errors

@mpampiszisios-ops mpampiszisios-ops left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx men

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants