use Catch2 version 3.x #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. We have upgraded to V3 for our incentive repo, but there was a reason that we didn't make these changes for Open-Source yet. I need to double check why. Perhaps those reasons don't apply anymore. (it might have been because of ubuntu is why we didn't pull the trigger yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 2022, Catch2 got a major update to v3.,slightly incompatible to v2. recent gentoo, ubuntu, opensuse, fedora have v3. while opensuse and fedora also provide a v2, gentoo and ubuntu 24.04 do not. ubuntu 22.04 provides v2 only.
anyhow: this PR should have the pymol source changes neccessary to migrate to catch2 v3.