Skip to content

Conversation

@speleo3
Copy link
Contributor

@speleo3 speleo3 commented Nov 4, 2025

Propagates cmd.get_object_list() errors from C++ to Python.

Does not change the empty string behavior yet
Changes the empty string behavior (#478)

Alternative to #481

Note: Suggest not to squash, second commit is deliberate to isolate the empty string behavior change

@pslacerda1
Copy link
Contributor

I think there is no reason to return None instead of raising an exception. Or return an object list of zero or more elements, or throw errors.

@speleo3 speleo3 force-pushed the get_object_list-error-propagation branch from 7b4f745 to 511485d Compare November 10, 2025 23:55
@speleo3
Copy link
Contributor Author

speleo3 commented Nov 11, 2025

I think there is no reason to return None instead of raising an exception

I do agree. I just wanted to keep that a separate change. I added a second commit now.

@pslacerda1
Copy link
Contributor

Perfect, thank you.

@JarrettSJohnson JarrettSJohnson merged commit 9375fd2 into schrodinger:master Nov 11, 2025
12 checks passed
@JarrettSJohnson
Copy link
Member

Thanks to the both of you for the discussion and contributions.

@speleo3 speleo3 deleted the get_object_list-error-propagation branch November 11, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants