fix: V1/V2 object header parsing - 100% test suite pass rate#13
Merged
Conversation
- Fix V1 header: correct end offset calculation (missing 16-byte prefix) - Fix V2 header: account for 4-byte CRC32 checksum at chunk end - Fix V2 header: 6-byte message headers when creation order tracked (bit 2) - Add soft link support: lazy resolution following C library behavior - Add Named Datatype (committed datatype) support - Official HDF5 test suite: 100% pass rate (378/378 valid files) - Add flux.h5 test file from Issue #9 reporter - Add test_results.txt to .gitignore
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #9 (continued) - comprehensive object header parsing fixes achieving 100% pass rate on official HDF5 test suite.
Bug Fixes
H5O_HDR_ATTR_CRT_ORDER_TRACKED(bit 2) is setResults
Test Plan
go test ./...passesgo test -race ./...passesgolangci-lint run ./...= 0 issuesTestOfficialHDF5Suite= 100% (378/378)flux.h5from Issue HDF5 files show up with no content #9 works correctlyCloses #9