fix: Jenkins lookup3 checksum for h5dump/h5py compatibility (Issue #17)#18
Merged
fix: Jenkins lookup3 checksum for h5dump/h5py compatibility (Issue #17)#18
Conversation
HDF5 requires Jenkins lookup3 hash for all metadata checksums, but we incorrectly used CRC32 IEEE. This caused V2/V3 superblock files to be rejected by h5dump, h5py, and the HDF5 C library. Changes: - Add JenkinsChecksum() in internal/core/checksum.go - Replace crc32.ChecksumIEEE with JenkinsChecksum in: - superblock.go (V2/V3 superblock checksum) - btreev2_write.go (B-tree v2 header/leaf checksums) - fractalheap_write.go (fractal heap header checksum) - fractalheap_indirect.go (indirect block checksum) Validated against aggr.h5 (checksum: 0xD5CB91E3) Closes #17
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JenkinsChecksum()function - direct port ofH5_checksum_lookup3()from HDF5 C libraryTest plan
Closes #17
Generated with Claude Code