Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WidgetStyle: add javadoc and new method #405

Merged
merged 1 commit into from
Sep 7, 2021
Merged

WidgetStyle: add javadoc and new method #405

merged 1 commit into from
Sep 7, 2021

Conversation

imagejan
Copy link
Member

While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon (:), for cases like "format:#0.001".

See also scijava/scijava-ui-swing#52.

@imagejan
Copy link
Member Author

@ctrueden just saw your comment here: #384 (comment)

If we're free to change the API of WidgetStyle, we could consider a) changing the return type of getModifiers() from String[] to Set<String> or b) removing the getModifiers signature entirely.

Also, I'm still open to (re-)naming suggestions :-)

imagejan added a commit to scijava/scijava-ui-swing that referenced this pull request Nov 1, 2020
imagejan added a commit to scijava/scijava-ui-swing that referenced this pull request Jan 10, 2021
While getStyleModifiers() is useful for things like "extensions:png/gif/bmp", this commit adds a new getStyleModifier() method that simply returns the suffix after the colon, for cases like "format:#0.001".

See also scijava/scijava-ui-swing#52.
@imagejan
Copy link
Member Author

@hinerm do you think this can be merged? Or alternatively, we can adapt the API introduced in #384, but I'm afraid there has been a release by now, so it would be a breaking API change (although no SciJava component was using it yet) ...

Anyhow, I think it would be good to get this done, so we can proceed with scijava/scijava-ui-swing#54 and scijava/scijava-ui-swing#56.

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/save-one-tiff-projection-from-a-current-view-in-bdv/33965/28

@hinerm hinerm merged commit e406d63 into master Sep 7, 2021
@imagejan imagejan deleted the more-widgetstyle branch September 7, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants