Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
|
Why the change in dependency? Is upstream not maintained, or lacking some feature, or ... ? |
LecrisUT
left a comment
There was a problem hiding this comment.
Main concern with this for me is having to carry the color definitions, formatting, etc. Would prefer for this to be the responsibility of furo, where they seem to have quite good designers, i.e. it could provide some css styles and this or sphinxcontrib-programoutput would simply format it to a pre-defined styles, like in the sphinx-contrib/ansi. My css knowledge is close to none, but I believe that that is also how they shift the colors in light and dark mode
|
I'd be happy to use an extension for this if there's a working one. There are also a few other options. I have implemented this with rich, but for mkdocs, in pypa/cibuildwheel#2407. I developed this for Sphinx in pypa/packaging#795 (in a comment, didn't add to the PR); there I was more aware of adding dependencies, so I did it without rich, but we could use rich here (and maybe there). That would probably look pretty good. This does support light/dark mode. As for plugins, https://github.com/OpenNTI/sphinxcontrib-programoutput hasn't had a release in over a year, and OpenNTI/sphinxcontrib-programoutput#49 was closed about 5 years ago. I did comment on that about a year ago with no response (though it is a closed issue). This seems to be since sphinxcontrib-ansi was last released 15 years ago and last touched 6 years ago. There is a nice suggestion on a new version in sphinx-contrib/ansi#12, but also untouched. |
LecrisUT
left a comment
There was a problem hiding this comment.
Well the dependency state is just bad around these. Guess this is better then nothing, if anything goes wrong maybe sphinx -W will catch it (we are running those right?)
b4cb1bb to
d97b794
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
d97b794 to
ed12c2e
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
|
I think the styling looks good in both modes (https://scikit-build-core--1218.org.readthedocs.build/en/1218/reference/cli.html) - let's go with this. |
|
Looks very promissing. Maybe let |
|
I've opened OpenNTI/sphinxcontrib-programoutput#73 (and several PRs), we'll see if it moves forward. |
Adding color to the CLI docs.